Disconnect old websockets#4953
Merged
Merged
Conversation
CodSpeed Performance ReportMerging #4953 will not alter performanceComparing Summary
|
Contributor
|
Related to #4607 I think. Disconnecting on new sid for same token means the original page will get disconnected? |
Collaborator
Author
yes; this is intended to handle the case where page is refreshed (in an iframe) or hot reloaded and ends up with a new websocket, but never closes out the old one. that said, i think the frontend logic might be good enough, and i wasn't actually able to hit that log message during actual testing. |
masenf
force-pushed
the
masenf/disconnect-old-websockets
branch
from
5d1d66c to
486de31
Compare
adhami3310
approved these changes
Mar 14, 2025
bhatia2akshit
pushed a commit
to bhatia2akshit/reflex
that referenced
this pull request
Mar 15, 2025
cutoffthetop
added a commit
to robert-koch-institut/mex-editor
that referenced
this pull request
Oct 10, 2025
### PR Context - this rollsback mx-1978, because of reflex-dev/reflex#4953, in favor of mx-2040 - the issue of the broken node/bun paths has been outsourced to mx-1995 ### Changes - update reflex to 0.7.3 - change integration of fastAPI endpoints - fix some component styling and python typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disconnect websockets more aggressively
when a new event comes in for the same token with a different sid(removed in this PR)