Skip to content

[0.8] [ENG-5825] remix over next#4984

Merged
adhami3310 merged 132 commits intomainfrom
remix-over-next
Jun 13, 2025
Merged

[0.8] [ENG-5825] remix over next#4984
adhami3310 merged 132 commits intomainfrom
remix-over-next

Conversation

@adhami3310
Copy link
Copy Markdown
Member

almost, usable, but needs to port 404, figure out titles and such, make sure events aren't broken, and bring back sitemap, among other things

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #4984 will degrade performances by 6.67%

Comparing remix-over-next (b795f12) with main (7f88d9d)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_get_all_imports[_complicated_page] 28.8 ms 26.6 ms +8.06%
test_get_all_imports[_stateful_page] 3.9 ms 3.7 ms +3.96%
test_evaluate_page[_complicated_page] 45.9 ms 49.1 ms -6.67%

@Alek99
Copy link
Copy Markdown
Member

Alek99 commented Mar 19, 2025

:)

Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a lot more to go on this, but i like the direction.

  • internal nav without breaking websocket
  • support dynamic routes (and hopefully translate existing syntax)
  • pre-render HTML and use hydrateRoot

In the future it would also be awesome to expose an interface for devs to specify additional dynamic routes that should be pre-rendered.

Some grunt work to get the tests passing, but i think we should try to keep this branch up to date with main and try to move over as soon as its stable and has feature parity.

It would be nice if things were implemented in a way that would allow us to support both, but that kind of refactoring work is probably not something we can prioritize over the wins from simplifying and shrinking our frontend stack, so probably makes sense to just move fast at this point and hard cut away from next.

@adhami3310
Copy link
Copy Markdown
Member Author

adhami3310 commented Mar 20, 2025

internal nav without breaking websocket
support dynamic routes (and hopefully translate existing syntax)

i was a bit stuck on these two, the code for them was very tied to nextjs way of doing things, so help there is appreciated

pre-render HTML and use hydrateRoot

we do have an SSR option but i don't know how much it does

there are also other things:

@adhami3310
Copy link
Copy Markdown
Member Author

JSX syntax to JS syntax trnasformation seems to be done (we can in theory make that its own PR)

@masenf
Copy link
Copy Markdown
Collaborator

masenf commented Jun 13, 2025

reflex-chakra no longer working

  File "/Users/masenf/code/reflex-dev/reflex/.venv/lib/python3.13/site-packages/reflex_chakra/components/navigation/breadcrumb.py", line 4, in <module>
    from reflex_chakra.components.navigation.link import Link
  File "/Users/masenf/code/reflex-dev/reflex/.venv/lib/python3.13/site-packages/reflex_chakra/components/navigation/link.py", line 5, in <module>
    from reflex.components.next.link import NextLink
ModuleNotFoundError: No module named 'reflex.components.next.link'

@masenf masenf changed the title [0.8] remix over next [0.8] [ENG-5825] remix over next Jun 13, 2025
Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 🔥 🚀

@adhami3310 adhami3310 merged commit c994b59 into main Jun 13, 2025
39 of 41 checks passed
@adhami3310 adhami3310 deleted the remix-over-next branch June 13, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants