Skip to content

treat small tuples different with figure out type#5161

Merged
adhami3310 merged 2 commits intomainfrom
khaleel/eng-5582-compiling-raises-a-typeerror-when-using-rxforeach
Apr 24, 2025
Merged

treat small tuples different with figure out type#5161
adhami3310 merged 2 commits intomainfrom
khaleel/eng-5582-compiling-raises-a-typeerror-when-using-rxforeach

Conversation

@adhami3310
Copy link
Copy Markdown
Member

fixes #5157

@linear
Copy link
Copy Markdown

linear bot commented Apr 22, 2025

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 22, 2025

CodSpeed Performance Report

Merging #5161 will not alter performance

Comparing khaleel/eng-5582-compiling-raises-a-typeerror-when-using-rxforeach (8cec2fd) with main (3bcf01d)

Summary

✅ 12 untouched benchmarks

@masenf
Copy link
Copy Markdown
Collaborator

masenf commented Apr 24, 2025

i filed a followup here #5173 to bring this awesome type guessing functionality for state vars 🤩

@adhami3310 adhami3310 merged commit f2565e0 into main Apr 24, 2025
42 checks passed
@adhami3310 adhami3310 deleted the khaleel/eng-5582-compiling-raises-a-typeerror-when-using-rxforeach branch April 24, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiling raises a TypeError when using rx.foreach.

2 participants