Skip to content

remove minor version from ci#5163

Merged
adhami3310 merged 4 commits into
mainfrom
remove-minor-version-from-ci
Apr 24, 2025
Merged

remove minor version from ci#5163
adhami3310 merged 4 commits into
mainfrom
remove-minor-version-from-ci

Conversation

@adhami3310

Copy link
Copy Markdown
Member

this should simplify updating our CI

@codspeed-hq

codspeed-hq Bot commented Apr 23, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #5163 will improve performances by 8.48%

Comparing remove-minor-version-from-ci (55a9fa2) with main (3bcf01d)

Summary

⚡ 6 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_page[_simple_page] 2.1 ms 2 ms +4.46%
test_compile_stateful[_complicated_page] 1,031 µs 993 µs +3.82%
test_compile_stateful[_simple_page] 268.8 µs 247.8 µs +8.48%
test_compile_stateful[_stateful_page] 361.7 µs 340.2 µs +6.34%
test_get_all_imports[_complicated_page] 30.7 ms 29.5 ms +4.27%
test_get_all_imports[_stateful_page] 3.9 ms 3.8 ms +3.51%

@masenf masenf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly seems faster w/o the cache 😂

@adhami3310 adhami3310 merged commit 35bfa42 into main Apr 24, 2025
@adhami3310 adhami3310 deleted the remove-minor-version-from-ci branch April 24, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants