Skip to content

ignore env var set to empty string#5167

Merged
adhami3310 merged 1 commit intomainfrom
ignore-env-var-set-to-empty-string
Apr 24, 2025
Merged

ignore env var set to empty string#5167
adhami3310 merged 1 commit intomainfrom
ignore-env-var-set-to-empty-string

Conversation

@adhami3310
Copy link
Copy Markdown
Member

fix #5138 even more

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 23, 2025

CodSpeed Performance Report

Merging #5167 will degrade performances by 4.73%

Comparing ignore-env-var-set-to-empty-string (88fb030) with main (3bcf01d)

Summary

❌ 2 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_evaluate_page[_complicated_page] 62.4 ms 64.4 ms -3.13%
test_evaluate_page[_simple_page] 827 µs 868.1 µs -4.73%

@adhami3310 adhami3310 merged commit d7f1cf5 into main Apr 24, 2025
41 of 42 checks passed
@adhami3310 adhami3310 deleted the ignore-env-var-set-to-empty-string branch April 24, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run reflex init without failing

2 participants