Merged
Conversation
If a component is memoized anywhere in the app, include the component in the generated output. Avoid extra component tree walk, since we can know immediately what all of the custom components are. Any perf optimization gained by not compiling unused memo functions is handily saved by avoiding the tree walk.
allow `@rx.memo` decorated functions to be referenced by dynamic components (which allows working around most limitations with dynamic components). move special cases for $/ prefix modules to `_normalize_library_path` and include them in `bundled_libraries` so they can be checked at runtime.
CodSpeed Performance ReportMerging #5172 will not alter performanceComparing Summary
|
adhami3310
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically compile any @rx.memo decorated function
If a component is memoized anywhere in the app, include the component in the generated output.
Avoid extra component tree walk, since we can know immediately what all of the custom components are. Any perf optimization gained by not compiling unused memo functions is handily saved by avoiding the tree walk.
dynamic: bundle local $/utils/components (rx.memo) module]
allow
@rx.memodecorated functions to be referenced by dynamic components (which allows working around most limitations with dynamic components).move special cases for $/ prefix modules to
_normalize_library_pathand include them inbundled_librariesso they can be checked at runtime.