Skip to content

validate classname#5204

Merged
adhami3310 merged 3 commits intomainfrom
khaleel/eng-5651-invalid-component-for-classname
Apr 29, 2025
Merged

validate classname#5204
adhami3310 merged 3 commits intomainfrom
khaleel/eng-5651-invalid-component-for-classname

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@linear
Copy link
Copy Markdown

linear bot commented Apr 29, 2025

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 29, 2025

CodSpeed Performance Report

Merging #5204 will improve performances by 4.14%

Comparing khaleel/eng-5651-invalid-component-for-classname (0cc1c38) with main (a24f08f)

Summary

⚡ 1 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_stateful[_simple_page] 259.1 µs 248.8 µs +4.14%

@adhami3310
Copy link
Copy Markdown
Member Author

blocked on reflex-dev/reflex-web#1324

what did i do

Co-authored-by: Masen Furer <m_github@0x26.net>
@adhami3310 adhami3310 merged commit 70ab9dc into main Apr 29, 2025
42 checks passed
@adhami3310 adhami3310 deleted the khaleel/eng-5651-invalid-component-for-classname branch April 29, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants