Skip to content

fix lifespan tasks regression #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masenf merged 10 commits into from
May 1, 2025
Merged

fix lifespan tasks regression #5218

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
29ff838
fix lifespan tasks regression
Lendemor Apr 30, 2025
aa5c995
fix lifespan issue even when transformer is used
Lendemor Apr 30, 2025
d276eb4
add_cors to top asgi app
Lendemor Apr 30, 2025
6f7d9fe
test_lifespan with FastAPI and api_transformer used
masenf Apr 30, 2025
fd571d2
avoid test warnings when _state_manager is not initialized
masenf May 1, 2025
2b3f177
call .app_instance() in the correct directory
masenf May 1, 2025
b2406d9
Call the app_instance to get the asgi object during initialization
masenf May 1, 2025
90fd2c4
revert unnecessary chdir scope
masenf May 1, 2025
ad15120
Merge remote-tracking branch 'origin/main' into lendemor/fix_lifespan…
masenf May 1, 2025
16198b4
revert more unnecessary changes
masenf May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reflex/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,8 @@ def __call__(self) -> ASGIApp:
if not self._api:
raise ValueError("The app has not been initialized.")
if self._cached_fastapi_app is not None:
asgi_app = self._cached_fastapi_app
asgi_app.mount("", self._api)
asgi_app = self._api
asgi_app.mount("", self._cached_fastapi_app)
App._add_cors(asgi_app)
else:
asgi_app = self._api
Expand Down
Loading