Skip to content

slicing a list is not a mutable proxy directly#5221

Merged
adhami3310 merged 1 commit intomainfrom
khaleel/eng-5436-when-slicing-a-state-variable-list-the-resulting-object-is
Apr 30, 2025
Merged

slicing a list is not a mutable proxy directly#5221
adhami3310 merged 1 commit intomainfrom
khaleel/eng-5436-when-slicing-a-state-variable-list-the-resulting-object-is

Conversation

@adhami3310
Copy link
Copy Markdown
Member

fixes #5097

@linear
Copy link
Copy Markdown

linear bot commented Apr 30, 2025

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 30, 2025

CodSpeed Performance Report

Merging #5221 will not alter performance

Comparing khaleel/eng-5436-when-slicing-a-state-variable-list-the-resulting-object-is (7eeb5e7) with main (c90b73a)

Summary

✅ 12 untouched benchmarks

@adhami3310 adhami3310 merged commit 6868b33 into main Apr 30, 2025
42 checks passed
@adhami3310 adhami3310 deleted the khaleel/eng-5436-when-slicing-a-state-variable-list-the-resulting-object-is branch April 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When slicing a state variable list, the resulting object is still wrapped in MutableProxy and tracks changes, even though it's a copy

2 participants