Skip to content

slicing a list is not a mutable proxy directly #5221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 1 commit into from
Apr 30, 2025
Merged

slicing a list is not a mutable proxy directly #5221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions reflex/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3937,6 +3937,8 @@ def __getitem__(self, key: Any) -> Any:
The item value.
"""
value = super().__getitem__(key)
if isinstance(key, slice) and isinstance(value, list):
return [self._wrap_recursive(item) for item in value]
# Recursively wrap mutable items retrieved through this proxy.
return self._wrap_recursive(value)

Expand Down
4 changes: 4 additions & 0 deletions tests/units/test_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1505,6 +1505,10 @@ def test_setattr_of_mutable_types(mutable_state: MutableTestState):
assert isinstance(array[1], list)
assert isinstance(array[2], MutableProxy)
assert isinstance(array[2], dict)
assert isinstance(array[:], list)
assert not isinstance(array[:], MutableProxy)
assert isinstance(array[:][1], MutableProxy)
assert isinstance(array[:][1], list)

assert isinstance(hashmap, MutableProxy)
assert isinstance(hashmap, dict)
Expand Down
Loading