Skip to content

revert _api to be fastapi#5222

Closed
adhami3310 wants to merge 1 commit intomainfrom
revert-_api-to-be-fastapi
Closed

revert _api to be fastapi#5222
adhami3310 wants to merge 1 commit intomainfrom
revert-_api-to-be-fastapi

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 30, 2025

CodSpeed Performance Report

Merging #5222 will degrade performances by 3.02%

Comparing revert-_api-to-be-fastapi (ff7e915) with main (c90b73a)

Summary

❌ 1 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_get_all_imports[_simple_page] 451.3 µs 465.3 µs -3.02%

@masenf
Copy link
Copy Markdown
Collaborator

masenf commented May 1, 2025

we'll hold off on this and instead fix the lifespan tasks in #5218

@masenf masenf closed this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants