-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[0.8] don't use reserve words for variable names #5251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
masenf
merged 26 commits into
main
from
khaleel/eng-5649-foreach-with-var-name-that-shadows-js-keyword-blows-up
Jun 16, 2025
Merged
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
9a7d317
don't use reserve words for variable names
adhami3310 4fe0fe0
use underscore suffix instead
adhami3310 9473762
fix various places that got the wrong name
adhami3310 4b5899d
fix the test
adhami3310 97d15b3
fix unit tests
adhami3310 449c00c
fix dynamic components
adhami3310 826c5d3
i don't know how to do inheritance
adhami3310 c3c4181
maybe
adhami3310 ac29df2
remove that suffix
adhami3310 bc8cc41
ok we can't do that
adhami3310 af74e9f
add something to update vars internal
adhami3310 db4aa45
fix dynamic route
adhami3310 02f60a5
Merge branch 'main' into khaleel/eng-5649-foreach-with-var-name-that-…
adhami3310 ec07336
fix unit tests
adhami3310 cf0cc12
fix is hydrated
adhami3310 89e418c
Merge remote-tracking branch 'origin/main' into khaleel/eng-5649-fore…
adhami3310 94baf77
solve post merge artifcats
adhami3310 edd5a12
simplify rx base
adhami3310 dc99619
fix a few more post merge artifacts
adhami3310 589c3f4
make all of those guys into a constant
adhami3310 9a23d48
Merge branch 'main' into khaleel/eng-5649-foreach-with-var-name-that-…
adhami3310 6cd1a42
it's ruff out there
adhami3310 f663a06
use field marker
adhami3310 2bf3046
Merge branch 'main' into khaleel/eng-5649-foreach-with-var-name-that-…
adhami3310 146d39a
add ignore field makrer
adhami3310 976934f
msg = msg replace
adhami3310 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.