Skip to content

When merging hook VarData, include the hook's VarData first#5283

Merged
adhami3310 merged 2 commits intomainfrom
masenf/merge-var-data-hooks-first
May 12, 2025
Merged

When merging hook VarData, include the hook's VarData first#5283
adhami3310 merged 2 commits intomainfrom
masenf/merge-var-data-hooks-first

Conversation

@masenf
Copy link
Copy Markdown
Collaborator

@masenf masenf commented May 11, 2025

The hook's VarData might be referencing some earlier hooks that are needed, so include the dependent VarData first so the dependencies render earlier in the output and can be referenced.

Needed for reflex-enterprise / react-dnd

The hook's VarData might be referencing some earlier hooks that are needed, so
include the dependent VarData first so the dependencies render earlier in the
output and can be referenced.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 11, 2025

CodSpeed Performance Report

Merging #5283 will not alter performance

Comparing masenf/merge-var-data-hooks-first (2f8759a) with main (60df907)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit c926b2f into main May 12, 2025
42 checks passed
@adhami3310 adhami3310 deleted the masenf/merge-var-data-hooks-first branch May 12, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants