Skip to content

remove pydantic as base class of component#5289

Merged
adhami3310 merged 19 commits intomainfrom
remove-pydantic-as-base-class-of-component
May 20, 2025
Merged

remove pydantic as base class of component#5289
adhami3310 merged 19 commits intomainfrom
remove-pydantic-as-base-class-of-component

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 13, 2025

CodSpeed Performance Report

Merging #5289 will improve performances by 35.13%

Comparing remove-pydantic-as-base-class-of-component (365fc8d) with main (69ca396)

Summary

⚡ 4 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_stateful[_complicated_page] 1,023.8 µs 757.6 µs +35.13%
test_compile_stateful[_stateful_page] 343.3 µs 293.6 µs +16.93%
test_evaluate_page[_complicated_page] 53.8 ms 45.6 ms +18.07%
test_evaluate_page[_stateful_page] 8.3 ms 7.1 ms +17.25%

Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

been working well for me over the past few days

subprocess.run(["git", "checkout", changed_file])

if cpu_count() == 1 or len(file_targets) < 5:
if True:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, i knew i forgot something, it's not even slower for me 💀

@adhami3310 adhami3310 merged commit 854ccd0 into main May 20, 2025
41 of 42 checks passed
@adhami3310 adhami3310 deleted the remove-pydantic-as-base-class-of-component branch May 20, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants