Skip to content

do not delete the .web dir when init-ing#5319

Merged
adhami3310 merged 1 commit intomainfrom
khaleel/eng-5934-permissions-of-the-web-directory-are-overwritten
May 21, 2025
Merged

do not delete the .web dir when init-ing#5319
adhami3310 merged 1 commit intomainfrom
khaleel/eng-5934-permissions-of-the-web-directory-are-overwritten

Conversation

@adhami3310
Copy link
Copy Markdown
Member

fix #5313

@linear
Copy link
Copy Markdown

linear bot commented May 20, 2025

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #5319 will not alter performance

Comparing khaleel/eng-5934-permissions-of-the-web-directory-are-overwritten (0e250c7) with main (f9b0d4d)

Summary

✅ 8 untouched benchmarks

Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so with this we're basically deleting the contents of the dest if it exists, but leaving the dest itself

@adhami3310 adhami3310 merged commit 59bbdcd into main May 21, 2025
42 checks passed
@adhami3310 adhami3310 deleted the khaleel/eng-5934-permissions-of-the-web-directory-are-overwritten branch May 21, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permissions of the .web directory are overwritten

2 participants