Skip to content

adjust rechart types#5336

Merged
Lendemor merged 3 commits intomainfrom
lendemor/adjust_rechart_types
May 29, 2025
Merged

adjust rechart types#5336
Lendemor merged 3 commits intomainfrom
lendemor/adjust_rechart_types

Conversation

@Lendemor
Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 23, 2025

CodSpeed Performance Report

Merging #5336 will not alter performance

Comparing lendemor/adjust_rechart_types (a2a691a) with main (12fc9f6)

Summary

✅ 8 untouched benchmarks

@Alek99 Alek99 self-requested a review May 24, 2025 00:53
Copy link
Copy Markdown
Member

@Alek99 Alek99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix any of the recharts problems or just remove component

@Lendemor
Copy link
Copy Markdown
Contributor Author

Lendemor commented May 26, 2025

Does this fix any of the recharts problems or just remove component

The current PR only allow for passing props dict as value for label props, which will be applied to the default label.

Passing Component would require some of the rx.memo rework we have planned but not done yet.

Alek99
Alek99 previously approved these changes May 29, 2025
@Alek99 Alek99 self-requested a review May 29, 2025 03:03
@Lendemor Lendemor merged commit b818961 into main May 29, 2025
42 checks passed
@Lendemor Lendemor deleted the lendemor/adjust_rechart_types branch May 29, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants