run get_app before checking for schema updates#5345
Closed
tartansandal wants to merge 1 commit intoreflex-dev:mainfrom
Closed
run get_app before checking for schema updates#5345tartansandal wants to merge 1 commit intoreflex-dev:mainfrom
tartansandal wants to merge 1 commit intoreflex-dev:mainfrom
Conversation
Member
|
i understand now 😅 you are correct in that it's not where we need to do particularly but it does give me a clue on how to do it, thanks for the contribution! |
Collaborator
|
fixed in #5348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures
prerequisiteshas access to the application models before checking for schema changes.Since version 0.7.9, I've been getting spurious "Detected database changes..." warnings when starting up my app, However, when I run
reflex db makemigrations, nothing is produced. I tweaked the code to show the phantom migration it was warning me and, to my surprise, it wanted to delete all the objects in my database. I believe this is because the prerequisites code could not see the app's models when checking for migrations. This PR resolve that, but it may not be the most sensible approach. 😅This may be related to and fix #5301