Skip to content

fix checking for migrations in granian#5348

Merged
adhami3310 merged 2 commits intomainfrom
khaleel/eng-5909-alembic-creates-migrations-of-tables-thats-migrations
May 29, 2025
Merged

fix checking for migrations in granian#5348
adhami3310 merged 2 commits intomainfrom
khaleel/eng-5909-alembic-creates-migrations-of-tables-thats-migrations

Conversation

@adhami3310
Copy link
Copy Markdown
Member

fixes #5301 and supersedes #5345

@linear
Copy link
Copy Markdown

linear bot commented May 27, 2025

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 27, 2025

CodSpeed Performance Report

Merging #5348 will not alter performance

Comparing khaleel/eng-5909-alembic-creates-migrations-of-tables-thats-migrations (5643951) with main (24cf764)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit f241d70 into main May 29, 2025
41 checks passed
@adhami3310 adhami3310 deleted the khaleel/eng-5909-alembic-creates-migrations-of-tables-thats-migrations branch May 29, 2025 20:23
Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me as well, i'm just slower than thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Alembic] Creates migrations of tables that's migrations already exist

3 participants