Skip to content

do not prematurely import app module if providing app_module_import #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 2 commits into from
May 28, 2025
Merged

do not prematurely import app module if providing app_module_import #5350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95e8f77
do not prematurely import app module if providing app_module_import
adhami3310 May 27, 2025
fb88abd
use .module
adhami3310 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reflex/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,8 +988,8 @@ def module(self) -> str:
Returns:
The module name.
"""
if self.app_module is not None:
return self.app_module.__name__
if self.app_module_import is not None:
return self.app_module_import
return ".".join([self.app_name, self.app_name])

def update_from_env(self) -> dict[str, Any]:
Expand Down
6 changes: 3 additions & 3 deletions reflex/utils/exec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,9 @@ def get_reload_paths() -> Sequence[Path]:
The reload paths for the backend.
"""
config = get_config()
reload_paths = [Path(config.app_name).parent]
if config.app_module is not None and config.app_module.__file__:
module_path = Path(config.app_module.__file__).resolve().parent
reload_paths = [Path.cwd()]
if (spec := importlib.util.find_spec(config.module)) is not None and spec.origin:
module_path = Path(spec.origin).resolve().parent

while module_path.parent.name and any(
sibling_file.name == "__init__.py"
Expand Down