Skip to content

do not run nextjs check on import #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 2 commits into from
May 28, 2025
Merged

do not run nextjs check on import #5352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
049f009
do not run nextjs check on import
adhami3310 May 27, 2025
2e810e8
dang it darglint
adhami3310 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions reflex/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,11 +1019,13 @@ def _get_frontend_packages(self, imports: dict[str, set[ImportVar]]):
Example:
>>> _get_frontend_packages({"react": "16.14.0", "react-dom": "16.14.0"})
"""
dependencies = constants.PackageJson.DEPENDENCIES
dev_dependencies = constants.PackageJson.DEV_DEPENDENCIES
page_imports = {
i
for i, tags in imports.items()
if i not in constants.PackageJson.DEPENDENCIES
and i not in constants.PackageJson.DEV_DEPENDENCIES
if i not in dependencies
and i not in dev_dependencies
and not any(i.startswith(prefix) for prefix in ["/", "$/", ".", "next/"])
and i != ""
and any(tag.install for tag in tags)
Expand Down
35 changes: 22 additions & 13 deletions reflex/constants/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,19 +113,28 @@ class Commands(SimpleNamespace):

_react_version = _determine_react_version()

DEPENDENCIES = {
"@emotion/react": "11.14.0",
"axios": "1.9.0",
"json5": "2.2.3",
"next": _determine_nextjs_version(),
"next-sitemap": "4.2.3",
"next-themes": "0.4.6",
"react": _react_version,
"react-dom": _react_version,
"react-focus-lock": "2.13.6",
"socket.io-client": "4.8.1",
"universal-cookie": "7.2.2",
}
@classproperty
@classmethod
def DEPENDENCIES(cls) -> dict[str, str]:
"""The dependencies to include in package.json.

Returns:
A dictionary of dependencies with their versions.
"""
return {
"@emotion/react": "11.14.0",
"axios": "1.9.0",
"json5": "2.2.3",
"next": _determine_nextjs_version(),
"next-sitemap": "4.2.3",
"next-themes": "0.4.6",
"react": cls._react_version,
"react-dom": cls._react_version,
"react-focus-lock": "2.13.6",
"socket.io-client": "4.8.1",
"universal-cookie": "7.2.2",
}

DEV_DEPENDENCIES = {
"autoprefixer": "10.4.21",
"postcss": "8.5.3",
Expand Down