Skip to content

fix infinite loop in pyi generator#5354

Merged
adhami3310 merged 1 commit intomainfrom
fix-infinite-loop-in-pyi-generator
May 29, 2025
Merged

fix infinite loop in pyi generator#5354
adhami3310 merged 1 commit intomainfrom
fix-infinite-loop-in-pyi-generator

Conversation

@adhami3310
Copy link
Copy Markdown
Member

fixes #5343

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 27, 2025

CodSpeed Performance Report

Merging #5354 will not alter performance

Comparing fix-infinite-loop-in-pyi-generator (1228c95) with main (c849cd8)

Summary

✅ 8 untouched benchmarks

@not-matthias
Copy link
Copy Markdown

Just FYI: managed to reproduce this while trying to install reflex on ARM with uv sync

@adhami3310
Copy link
Copy Markdown
Member Author

Just FYI: managed to reproduce this while trying to install reflex on ARM with uv sync

on this branch or on main?

@not-matthias
Copy link
Copy Markdown

not-matthias commented May 28, 2025

on this branch or on main?

on main, just wanted to let you know in case something like this happens again. cause i noticed you don't have ARM benches that could've caught this in advance.

See: https://github.com/AvalancheHQ/reflex-perf/actions/runs/15273409165/job/42960811377

@adhami3310 adhami3310 merged commit ae66ab6 into main May 29, 2025
42 checks passed
@adhami3310 adhami3310 deleted the fix-infinite-loop-in-pyi-generator branch May 29, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants