Skip to content

fix infinite loop in pyi generator #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 1 commit into from
May 29, 2025
Merged

fix infinite loop in pyi generator #5354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 32 additions & 27 deletions reflex/utils/pyi_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@

PWD = Path.cwd()

PYI_HASHES = "pyi_hashes.json"

EXCLUDED_FILES = [
"app.py",
"component.py",
Expand Down Expand Up @@ -1264,45 +1266,48 @@ def scan_all(
file_parent = file_path.parent
while len(file_parent.parts) > len(top_dir.parts):
file_parent = file_parent.parent
while len(top_dir.parts) > len(file_parent.parts):
top_dir = top_dir.parent
while not file_parent.samefile(top_dir):
file_parent = file_parent.parent
top_dir = top_dir.parent

pyi_hashes_file = top_dir / "pyi_hashes.json"
if not pyi_hashes_file.exists():
while top_dir.parent and not (top_dir / "pyi_hashes.json").exists():
top_dir = top_dir.parent
another_pyi_hashes_file = top_dir / "pyi_hashes.json"
if another_pyi_hashes_file.exists():
pyi_hashes_file = another_pyi_hashes_file

pyi_hashes_file.write_text(
json.dumps(
dict(
zip(
[
f.relative_to(pyi_hashes_file.parent).as_posix()
for f in file_paths
],
hashes,
strict=True,
)
),
indent=2,
sort_keys=True,
while (
not top_dir.samefile(top_dir.parent)
and not (top_dir / PYI_HASHES).exists()
):
top_dir = top_dir.parent

pyi_hashes_file = top_dir / PYI_HASHES

if pyi_hashes_file.exists():
pyi_hashes_file.write_text(
json.dumps(
dict(
zip(
[
f.relative_to(pyi_hashes_file.parent).as_posix()
for f in file_paths
],
hashes,
strict=True,
)
),
indent=2,
sort_keys=True,
)
+ "\n",
)
+ "\n",
)
elif file_paths:
file_paths = list(map(Path, file_paths))
pyi_hashes_parent = file_paths[0].parent
while (
pyi_hashes_parent.parent
and not (pyi_hashes_parent / "pyi_hashes.json").exists()
not pyi_hashes_parent.samefile(pyi_hashes_parent.parent)
and not (pyi_hashes_parent / PYI_HASHES).exists()
):
pyi_hashes_parent = pyi_hashes_parent.parent

pyi_hashes_file = pyi_hashes_parent / "pyi_hashes.json"
pyi_hashes_file = pyi_hashes_parent / PYI_HASHES
if pyi_hashes_file.exists():
pyi_hashes = json.loads(pyi_hashes_file.read_text())
for file_path, hashed_content in zip(
Expand Down