From 4d355096bc9ebc3e18eb0c716b185dc6b7202ba7 Mon Sep 17 00:00:00 2001 From: Khaleel Al-Adhami Date: Wed, 28 May 2025 18:14:29 -0700 Subject: [PATCH 1/2] make get_props use get_js_fields --- reflex/components/component.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reflex/components/component.py b/reflex/components/component.py index 73fd5fe3efd..bc5eba623dd 100644 --- a/reflex/components/component.py +++ b/reflex/components/component.py @@ -1015,7 +1015,7 @@ def get_props(cls) -> set[str]: Returns: The unique fields. """ - return set(cls.get_fields()) - set(Component.get_fields()) + return set(cls.get_js_fields()) @classmethod @functools.cache From b698dbd473d7be757f88af93ccea6a8d1cb77940 Mon Sep 17 00:00:00 2001 From: Khaleel Al-Adhami Date: Wed, 28 May 2025 18:21:51 -0700 Subject: [PATCH 2/2] we want all fields --- reflex/components/component.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/reflex/components/component.py b/reflex/components/component.py index bc5eba623dd..6a9c320dc69 100644 --- a/reflex/components/component.py +++ b/reflex/components/component.py @@ -286,10 +286,11 @@ def __new__(cls, name: str, bases: tuple[type], namespace: dict[str, Any]) -> ty namespace["_own_fields"] = own_fields namespace["_inherited_fields"] = inherited_fields - namespace["_fields"] = inherited_fields | own_fields + all_fields = inherited_fields | own_fields + namespace["_fields"] = all_fields namespace["_js_fields"] = { key: value - for key, value in own_fields.items() + for key, value in all_fields.items() if value.is_javascript is True } return super().__new__(cls, name, bases, namespace)