Skip to content

make get_props use get_js_fields #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 2 commits into from
May 29, 2025
Merged

make get_props use get_js_fields #5361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d35509
make get_props use get_js_fields
adhami3310 May 29, 2025
b698dbd
we want all fields
adhami3310 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions reflex/components/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,10 +286,11 @@ def __new__(cls, name: str, bases: tuple[type], namespace: dict[str, Any]) -> ty

namespace["_own_fields"] = own_fields
namespace["_inherited_fields"] = inherited_fields
namespace["_fields"] = inherited_fields | own_fields
all_fields = inherited_fields | own_fields
namespace["_fields"] = all_fields
namespace["_js_fields"] = {
key: value
for key, value in own_fields.items()
for key, value in all_fields.items()
if value.is_javascript is True
}
return super().__new__(cls, name, bases, namespace)
Expand Down Expand Up @@ -1015,7 +1016,7 @@ def get_props(cls) -> set[str]:
Returns:
The unique fields.
"""
return set(cls.get_fields()) - set(Component.get_fields())
return set(cls.get_js_fields())

@classmethod
@functools.cache
Expand Down