no need to kill nextjs on package change#5389
Merged
adhami3310 merged 2 commits intomainfrom Jun 2, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #5389 will not alter performanceComparing Summary
|
Lendemor
reviewed
Jun 2, 2025
Comment on lines
+117
to
+126
| dependencies_change = get_changes( | ||
| old_package_json_content.get("dependencies", {}), | ||
| new_package_json_content.get("dependencies", {}), | ||
| ) | ||
| dev_dependencies_change = get_changes( | ||
| old_package_json_content.get("devDependencies", {}), | ||
| new_package_json_content.get("devDependencies", {}), | ||
| ) | ||
|
|
||
| return dependencies_change, dev_dependencies_change |
Contributor
There was a problem hiding this comment.
Suggested change
| dependencies_change = get_changes( | |
| old_package_json_content.get("dependencies", {}), | |
| new_package_json_content.get("dependencies", {}), | |
| ) | |
| dev_dependencies_change = get_changes( | |
| old_package_json_content.get("devDependencies", {}), | |
| new_package_json_content.get("devDependencies", {}), | |
| ) | |
| return dependencies_change, dev_dependencies_change | |
| return tuple( | |
| get_changes( | |
| old_package_json_content.get(deps_key, {}), | |
| new_package_json_content.get(deps_key, {}), | |
| ) | |
| for deps_key in PackageJson.__annotations__ | |
| ) |
Member
Author
There was a problem hiding this comment.
this makes the typing looser, so i would prefer to keep explicit for now
Contributor
There was a problem hiding this comment.
Make sense for the explicit.
Are the intermediary variable just there for easier reading ? because we could do explicit in the return expression right?
Member
Author
There was a problem hiding this comment.
just there for easier reading
yea it's also to declutter a long return line
Lendemor
approved these changes
Jun 2, 2025
masenf
approved these changes
Jun 2, 2025
adhami3310
added a commit
that referenced
this pull request
Jun 2, 2025
* no need to kill nextjs on package change * make it info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also adds helpful messages