Skip to content

no need to kill nextjs on package change#5389

Merged
adhami3310 merged 2 commits intomainfrom
no-need-to-kill-nextjs-on-package-change
Jun 2, 2025
Merged

no need to kill nextjs on package change#5389
adhami3310 merged 2 commits intomainfrom
no-need-to-kill-nextjs-on-package-change

Conversation

@adhami3310
Copy link
Copy Markdown
Member

also adds helpful messages

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 31, 2025

CodSpeed Performance Report

Merging #5389 will not alter performance

Comparing no-need-to-kill-nextjs-on-package-change (0db6f89) with main (8c24e8f)

Summary

✅ 8 untouched benchmarks

Comment thread reflex/utils/exec.py
Comment on lines +117 to +126
dependencies_change = get_changes(
old_package_json_content.get("dependencies", {}),
new_package_json_content.get("dependencies", {}),
)
dev_dependencies_change = get_changes(
old_package_json_content.get("devDependencies", {}),
new_package_json_content.get("devDependencies", {}),
)

return dependencies_change, dev_dependencies_change
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dependencies_change = get_changes(
old_package_json_content.get("dependencies", {}),
new_package_json_content.get("dependencies", {}),
)
dev_dependencies_change = get_changes(
old_package_json_content.get("devDependencies", {}),
new_package_json_content.get("devDependencies", {}),
)
return dependencies_change, dev_dependencies_change
return tuple(
get_changes(
old_package_json_content.get(deps_key, {}),
new_package_json_content.get(deps_key, {}),
)
for deps_key in PackageJson.__annotations__
)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes the typing looser, so i would prefer to keep explicit for now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense for the explicit.

Are the intermediary variable just there for easier reading ? because we could do explicit in the return expression right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just there for easier reading

yea it's also to declutter a long return line

@adhami3310 adhami3310 merged commit a49558b into main Jun 2, 2025
41 checks passed
@adhami3310 adhami3310 deleted the no-need-to-kill-nextjs-on-package-change branch June 2, 2025 18:06
adhami3310 added a commit that referenced this pull request Jun 2, 2025
* no need to kill nextjs on package change

* make it info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants