Skip to content

add on_scroll_end event#5401

Merged
adhami3310 merged 8 commits intomainfrom
lendemor/add_scroll_end_event
Jun 6, 2025
Merged

add on_scroll_end event#5401
adhami3310 merged 8 commits intomainfrom
lendemor/add_scroll_end_event

Conversation

@Lendemor
Copy link
Copy Markdown
Contributor

@Lendemor Lendemor commented Jun 2, 2025

From experimentation, on_scroll is kinda spammy during scroll events, so it might be useful to have one that fire once per scroll, when it end.

It's a no_args_event_spec for now because I didn't find much useful data inside the event that is fired on that trigger.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 2, 2025

CodSpeed Performance Report

Merging #5401 will not alter performance

Comparing lendemor/add_scroll_end_event (1862a81) with main (85af94b)

Summary

✅ 8 untouched benchmarks

@adhami3310
Copy link
Copy Markdown
Member

safari doesn't support this, do we care?

@Lendemor
Copy link
Copy Markdown
Contributor Author

Lendemor commented Jun 6, 2025

safari doesn't support this, do we care?

That's a Safari problem isn't it?
We follow the MDN specifications, if Safari doesn't want to support it, not much we can do, but no reason to keep other browsers from using the feature.

Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentative approval provided docs are appropriately updated

@adhami3310 adhami3310 merged commit c23ffce into main Jun 6, 2025
41 checks passed
@adhami3310 adhami3310 deleted the lendemor/add_scroll_end_event branch June 6, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants