ignore visited components for all_app_wrap_components#5404
Merged
adhami3310 merged 1 commit intomainfrom Jun 2, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Implements optimization in component traversal by preventing infinite recursion and duplicate processing in _get_all_app_wrap_components method across Bare and Component classes.
- Added
ignore_idsparameter in/reflex/components/base/bare.pyto track processed component IDs - Modified
/reflex/components/component.pyto check component IDs against ignore set before recursion - Improved performance for complex component hierarchies by eliminating redundant processing
- Enhanced stack overflow protection through systematic tracking of visited components
💡 (5/5) You can turn off certain types of comments like style here!
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Lendemor
approved these changes
Jun 2, 2025
CodSpeed Performance ReportMerging #5404 will not alter performanceComparing Summary
|
adhami3310
deleted the
ignore-visited-components-for-all_app_wrap_components
branch
adhami3310
added a commit
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.