compile custom components before we get app wraps of the pages#5405
Merged
adhami3310 merged 2 commits intomainfrom Jun 2, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Optimizes the compilation order in reflex/app.py by moving custom component compilation before page processing, ensuring components are available during the rendering phase.
- Moved custom component compilation block before the page processing loop to prevent potential rendering issues
- Ensures custom components are fully compiled before any recursive component traversal begins
- Improves dependency resolution by having all components available during the initial render phase
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5405 will not alter performanceComparing Summary
|
Lendemor
approved these changes
Jun 2, 2025
adhami3310
deleted the
compile-custom-components-before-we-get-app-wraps-of-the-pages
branch
adhami3310
added a commit
that referenced
this pull request
Jun 3, 2025
* compile custom components before we get app wraps of the pages * maybe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.