Skip to content

compile custom components before we get app wraps of the pages #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 2 commits into from
Jun 2, 2025
Merged

compile custom components before we get app wraps of the pages #5405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e335c0f
compile custom components before we get app wraps of the pages
adhami3310 Jun 2, 2025
34a33b2
maybe
adhami3310 Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions reflex/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,15 +1293,6 @@ def get_compilation_time() -> str:
# Track imports found.
all_imports = {}

# This has to happen before compiling stateful components as that
# prevents recursive functions from reaching all components.
for component in self._pages.values():
# Add component._get_all_imports() to all_imports.
all_imports.update(component._get_all_imports())

# Add the app wrappers from this component.
app_wrappers.update(component._get_all_app_wrap_components())

if (toaster := self.toaster) is not None:
from reflex.components.component import memo

Expand All @@ -1319,6 +1310,25 @@ def memoized_toast_provider():
if component is not None:
app_wrappers[key] = component

# Compile custom components.
(
custom_components_output,
custom_components_result,
custom_components_imports,
) = compiler.compile_components(dict.fromkeys(CUSTOM_COMPONENTS.values()))
compile_results.append((custom_components_output, custom_components_result))
all_imports.update(custom_components_imports)
progress.advance(task)

# This has to happen before compiling stateful components as that
# prevents recursive functions from reaching all components.
for component in self._pages.values():
# Add component._get_all_imports() to all_imports.
all_imports.update(component._get_all_imports())

# Add the app wrappers from this component.
app_wrappers.update(component._get_all_app_wrap_components())

if self.error_boundary:
from reflex.compiler.compiler import into_component

Expand Down Expand Up @@ -1465,16 +1475,6 @@ def _submit_work_without_advancing(
)
progress.advance(task)

# Compile custom components.
(
custom_components_output,
custom_components_result,
custom_components_imports,
) = compiler.compile_components(dict.fromkeys(CUSTOM_COMPONENTS.values()))
compile_results.append((custom_components_output, custom_components_result))
all_imports.update(custom_components_imports)

progress.advance(task)
progress.stop()

if dry_run:
Expand Down