Skip to content

add a check if app_name is wrong in rxconfig#5410

Merged
Lendemor merged 7 commits into
mainfrom
lendemor/app_name_failsafe
Jun 4, 2025
Merged

add a check if app_name is wrong in rxconfig#5410
Lendemor merged 7 commits into
mainfrom
lendemor/app_name_failsafe

Conversation

@Lendemor
Copy link
Copy Markdown
Contributor

@Lendemor Lendemor commented Jun 3, 2025

No description provided.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added validation for app folder structure to ensure it matches the app_name specified in rxconfig.py. This helps catch configuration mismatches early.

  • Added _check_app_folder_structure() in reflex/utils/prerequisites.py to validate app folder and main file existence
  • Function checks if app folder exists at <cwd>/<app_name> and main file at <app_name>/<app_name>.py
  • Validation is skipped if custom app_module_import is specified in config
  • Raises clear error messages if folder structure doesn't match config
  • Integrated check into get_app() flow after _check_app_name()

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 3, 2025

CodSpeed Performance Report

Merging #5410 will not alter performance

Comparing lendemor/app_name_failsafe (5dc0346) with main (9e5a410)

Summary

✅ 8 untouched benchmarks

Comment thread reflex/utils/prerequisites.py Outdated
@Lendemor Lendemor merged commit 90a888b into main Jun 4, 2025
41 checks passed
@Lendemor Lendemor deleted the lendemor/app_name_failsafe branch June 4, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants