add generic field to get_state in proxy#5415
Merged
masenf merged 1 commit intoJun 6, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Enhanced type safety in StateProxy's get_state method by adding generic type hints, improving IDE support and static type checking capabilities.
- Added
T_STATETypeVar bound toBaseStateinreflex/istate/proxy.pyto ensureget_statereturns the exact passed state type - Added
pyright-ignorecomment to handle type checking limitations with wrapped return types
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5415 will not alter performanceComparing Summary
|
masenf
deleted the
khaleel/eng-6131-get_state-annotation-should-reflect-the-fact-that-it-returns
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5414