fix missing value for mutable state field leading to shared field value#5416
Merged
adhami3310 merged 1 commit intoJun 6, 2025
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Fixed a critical bug in state management where mutable default values were being incorrectly shared across instances of state fields in reflex/vars/base.py.
- Added deep copy mechanism for mutable default values to ensure each state instance gets its own independent copy
- Implemented type-based default value detection with immutability check to prevent shared references
- Fixed potential memory leaks and unexpected behavior in event actions caused by shared mutable state
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5416 will not alter performanceComparing Summary
|
Lendemor
approved these changes
Jun 6, 2025
adhami3310
deleted the
fix-missing-value-for-mutable-state-field-leading-to-shared-field-value
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix the event actions