Skip to content

fix default body style#5468

Merged
adhami3310 merged 5 commits into
mainfrom
lendemor/default_body_style
Jun 18, 2025
Merged

fix default body style#5468
adhami3310 merged 5 commits into
mainfrom
lendemor/default_body_style

Conversation

@Lendemor
Copy link
Copy Markdown
Contributor

Remove the default margin added by some browser on the <body> tag.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified browser behavior by removing default margin from <body> tag for consistent cross-browser styling.

  • Added margin=0 style to root Body component in reflex/compiler/utils.py:create_document_root() to ensure consistent spacing across different browsers

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 18, 2025

CodSpeed Performance Report

Merging #5468 will not alter performance

Comparing lendemor/default_body_style (27c95a2) with main (d9d6fb8)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit a0d508c into main Jun 18, 2025
52 of 53 checks passed
@adhami3310 adhami3310 deleted the lendemor/default_body_style branch June 18, 2025 23:46
masenf pushed a commit that referenced this pull request Jun 19, 2025
* fix default body style

* wip vendored preflight

* fricking dumb claude

* fix layer issue

* fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants