ENG-6363: remix: ignore some changes in .web to reduce reloads#5473
Merged
Conversation
ignore .web/backend and .web/reflex.install_frontend_packages.cached to avoid spurious additional full-reload
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Optimizes development server performance by configuring Vite to ignore specific paths that trigger unnecessary full page reloads.
- Modified
reflex/.templates/web/vite.config.jsto exclude.web/backend/**and.web/reflex.install_frontend_packages.cachedfrom file watching - This change prevents redundant reloads when backend files change or frontend packages are installed
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Lendemor
previously approved these changes
Jun 18, 2025
CodSpeed Performance ReportMerging #5473 will not alter performanceComparing Summary
|
If the app is stateless, then the on_error is a no-op, but having it here means that any issues arising during HMR are caught by _our_ boundary, not the default, which halts execution of the script, when simply reloading again can resolve the issue.
masenf
changed the title
Lendemor
approved these changes
Jun 19, 2025
masenf
added a commit
that referenced
this pull request
Jun 19, 2025
* remix: ignore some changes in .web to reduce reloads ignore .web/backend and .web/reflex.install_frontend_packages.cached to avoid spurious additional full-reload * ENG-6363: Ensure ErrorBoundary is always in the AppWrap If the app is stateless, then the on_error is a no-op, but having it here means that any issues arising during HMR are caught by _our_ boundary, not the default, which halts execution of the script, when simply reloading again can resolve the issue. * update test expectation now that ErrorBoundary is always there * test_call_script: Poll for the last external function to be defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore .web/backend and .web/reflex.install_frontend_packages.cached to avoid spurious additional full-reload