avoid side effects of checking app module existing#5480
Merged
adhami3310 merged 1 commit intoJun 23, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR improves module path detection by replacing importlib.util.find_spec() with a safer custom implementation to prevent unintended module imports during path inspection.
- Added new
get_module_path()inreflex/utils/misc.pythat safely checks module existence without side effects - Refactored
get_app_file()andget_reload_paths()inreflex/utils/exec.pyto use the new helper function - Removed unnecessary origin path validation in
reflex/utils/prerequisites.pyfor more robust module path handling
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+46
to
+48
| else: | ||
| return current_path / "__init__.py" # Made it through all parts | ||
|
|
Contributor
There was a problem hiding this comment.
logic: The else clause will only trigger if the loop completes without a break, meaning we found all parts as directories. However, we need to check if the final path actually exists before returning.
CodSpeed Performance ReportMerging #5480 will not alter performanceComparing Summary
|
masenf
approved these changes
Jun 23, 2025
adhami3310
deleted the
khaleel/eng-6378-internal-usage-of-find_spec-results-in-unexpected-import-of
branch
masenf
pushed a commit
that referenced
this pull request
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.