bring back the "route" in router data#5483
Merged
adhami3310 merged 8 commits intoJun 23, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Extensive overhaul of Reflex's routing system to support optional routes with double brackets [[...]] and improve route conflict detection, while simplifying route formatting and validation logic.
- Added robust route conflict detection in
reflex/route.pywith comprehensive validation for dynamic, optional, and catchall routes - Introduced new route patterns in
reflex/constants/route.pyincluding OPTIONAL_CATCHALL and OPTIONAL_ARG for double-bracketed routes - Simplified route formatting by removing case formatting options in
reflex/utils/format.py - Updated test suite with extensive route conflict testing scenarios in
tests/units/test_route.py - Streamlined load event handling in
reflex/app.pywith more efficient storage and simplified route parsing
8 files reviewed, 6 comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5483 will not alter performanceComparing Summary
|
adhami3310
deleted the
khaleel/eng-6298-get-symbolic-path-for-dynamic-routes
branch
masenf
pushed a commit
that referenced
this pull request
Jun 26, 2025
* bring back the "route" in router data * heh * typo * typo * fix the unit tests * fix dynamic route test * huh???? * fix one unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also adds back double bracket for optional routes