clean up random fields that aren't marked correctly as not javascript fields#5484
Merged
adhami3310 merged 5 commits intoJun 24, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Modified the component system's JavaScript field detection in reflex/components/component.py to rely on is_javascript flags instead of Var type checking, addressing issue #5427 regarding component import issues.
- Changed core component field detection logic to use explicit
is_javascriptflags rather thanVartype checks, potentially impacting how JavaScript-compatible props are determined
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Member
Author
|
no longer fixes #5427 hehe |
CodSpeed Performance ReportMerging #5484 will not alter performanceComparing Summary
|
masenf
reviewed
Jun 24, 2025
Comment on lines
-31
to
-41
| # The description of character encoding. | ||
| char_set: str | None = None | ||
|
|
||
| # The value of meta. | ||
| content: str | None = None | ||
|
|
||
| # The name of metadata. | ||
| name: str | None = None | ||
|
|
||
| # The type of metadata value. | ||
| property: str | None = None |
Collaborator
There was a problem hiding this comment.
why are we removing these?
adhami3310
changed the title
masenf
approved these changes
Jun 24, 2025
adhami3310
deleted the
treat-all-is_javascript-that-are-not-events-as-vars
branch
masenf
pushed a commit
that referenced
this pull request
Jun 26, 2025
… fields (#5484) * treat all is_javascript that are not events as vars * fix markdown element * clean up some stuff * pyi generate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a bit sus i will be looking at the tests, fixes #5427