Ensure __reflex_base CSS is declared first#5493
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Addresses CSS specificity issues by adding explicit @layer __reflex_base declaration in reflex/.templates/jinja/web/styles/styles.css.jinja2 to prevent base styles from incorrectly overriding Tailwind and Radix styles.
- Added explicit layer ordering in
styles.css.jinja2to ensure proper CSS cascade hierarchy - Fixes style precedence issue where reset CSS was taking precedence over component frameworks
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Darksinian
previously approved these changes
Jun 25, 2025
CodSpeed Performance ReportMerging #5493 will not alter performanceComparing Summary
|
adhami3310
approved these changes
Jun 25, 2025
masenf
added a commit
that referenced
this pull request
Jun 26, 2025
* Ensure __reflex_base CSS is declared first * fixup unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, we see the reset taking over tailwind and radix styles...