Skip to content

Ensure __reflex_base CSS is declared first#5493

Merged
masenf merged 2 commits into
mainfrom
masenf/css-reset-touchup
Jun 25, 2025
Merged

Ensure __reflex_base CSS is declared first#5493
masenf merged 2 commits into
mainfrom
masenf/css-reset-touchup

Conversation

@masenf
Copy link
Copy Markdown
Collaborator

@masenf masenf commented Jun 25, 2025

Without this, we see the reset taking over tailwind and radix styles...

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Addresses CSS specificity issues by adding explicit @layer __reflex_base declaration in reflex/.templates/jinja/web/styles/styles.css.jinja2 to prevent base styles from incorrectly overriding Tailwind and Radix styles.

  • Added explicit layer ordering in styles.css.jinja2 to ensure proper CSS cascade hierarchy
  • Fixes style precedence issue where reset CSS was taking precedence over component frameworks

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Darksinian
Darksinian previously approved these changes Jun 25, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 25, 2025

CodSpeed Performance Report

Merging #5493 will not alter performance

Comparing masenf/css-reset-touchup (7727f2d) with main (9d5d59b)

Summary

✅ 8 untouched benchmarks

@masenf masenf merged commit aaea4cc into main Jun 25, 2025
41 checks passed
@masenf masenf deleted the masenf/css-reset-touchup branch June 25, 2025 03:43
masenf added a commit that referenced this pull request Jun 26, 2025
* Ensure __reflex_base CSS is declared first

* fixup unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants