Include default metas for char_set and viewport#5500
Merged
Conversation
If the user does not override the char_set or viewport metas with their own, then include these as defaults.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Modified document root creation logic to automatically include default meta tags for character set and viewport unless explicitly overridden by user-defined head components.
- Updated
reflex/compiler/utils.pyto conditionally includechar_set="utf-8"and viewport meta tags as defaults - Fixes hydration errors caused by Remix's developer greeting when UTF-8 charset isn't explicitly specified
- Maintains backward compatibility while improving flexibility for custom head component configurations
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5500 will not alter performanceComparing Summary
|
adhami3310
previously approved these changes
Jun 26, 2025
adhami3310
reviewed
Jun 26, 2025
Because if you don't test, then you assuredly have bugs or will.
adhami3310
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user does not override the char_set or viewport metas with their own, then include these as defaults.
Fixes the annoying hydration error that appears when remix sends its dumb "Hey developer 👋" message on the console, which happened when the app didn't specify
utf-8as its char_set (which would happen if the app used any customhead_components)