Skip to content

Include default metas for char_set and viewport #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 5 commits into from
Jun 26, 2025
Merged

Include default metas for char_set and viewport #5500

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50c3e5b
Include default metas for char_set and viewport
masenf Jun 26, 2025
e7a8000
fix tests
masenf Jun 26, 2025
320a080
Create actual test cases for this feature
masenf Jun 26, 2025
da13ad6
handle the fact that props are Var
masenf Jun 26, 2025
b0db493
Merge remote-tracking branch 'origin/main' into masenf/include-meta-u…
masenf Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions reflex/compiler/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,21 +359,34 @@ def create_document_root(
Returns:
The document root.
"""
head_components = [
*(
head_components
or [
# Default meta tags if user does not provide.
Meta.create(char_set="utf-8"),
Meta.create(
name="viewport", content="width=device-width, initial-scale=1"
),
]
),
# Always include the framework meta and link tags.
existing_meta_types = set()

for component in head_components or []:
if isinstance(component, Meta):
if component.char_set: # pyright: ignore[reportAttributeAccessIssue]
existing_meta_types.add("char_set")
if component.name == "viewport": # pyright: ignore[reportAttributeAccessIssue]
existing_meta_types.add("viewport")
Comment thread
adhami3310 marked this conversation as resolved.
Outdated

# Always include the framework meta and link tags.
always_head_components = [
ReactMeta.create(),
Links.create(),
]
maybe_head_components = []
# Only include these if the user has not specified them.
if "char_set" not in existing_meta_types:
maybe_head_components.append(Meta.create(char_set="utf-8"))
if "viewport" not in existing_meta_types:
maybe_head_components.append(
Meta.create(name="viewport", content="width=device-width, initial-scale=1")
)

head_components = [
*(head_components or []),
*maybe_head_components,
*always_head_components,
]
return Html.create(
Head.create(*head_components),
Body.create(
Expand Down
4 changes: 2 additions & 2 deletions tests/units/compiler/test_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,9 @@ def test_create_document_root():
html_custom_attrs={"project": "reflex"},
)
assert isinstance(root, utils.Html)
assert len(root.children[0].children) == 4
assert len(root.children[0].children) == 6
names = [c.tag for c in root.children[0].children]
assert names == ["Scripts", "Scripts", "Meta", "Links"]
assert names == ["Scripts", "Scripts", "meta", "meta", "Meta", "Links"]
lang = root.lang # pyright: ignore [reportAttributeAccessIssue]
assert isinstance(lang, LiteralStringVar)
assert lang.equals(Var.create("rx"))
Expand Down