remove init requirement to figure out if the app exists#5507
Merged
adhami3310 merged 1 commit intoJun 26, 2025
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Modified package detection logic in reflex/utils/misc.py to remove the requirement for __init__.py files, enabling support for PEP 420 namespace packages.
- Significant change to
get_module_pathfunction that now treats any directory as a potential package without requiring__init__.py - Could impact module resolution behavior and how Reflex identifies valid Python packages
- May require careful testing with existing projects that rely on traditional package structures
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+40
to
43
| if potential_dir.is_dir(): | ||
| # It's a package, so we can continue deeper | ||
| current_path = potential_dir | ||
| else: |
Contributor
There was a problem hiding this comment.
logic: traversing directories without init.py check could include non-package directories, potentially causing incorrect module resolution
Member
Author
There was a problem hiding this comment.
that's the point you dumbass
CodSpeed Performance ReportMerging #5507 will not alter performanceComparing Summary
|
masenf
approved these changes
Jun 26, 2025
adhami3310
deleted the
remove-init-requirement-to-figure-out-the-import-guy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.