add url and route_id to routerdata as a replacement for pagedata#5516
Merged
adhami3310 merged 4 commits intoJul 2, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Major refactoring to transition from PageData to RouterData by adding URL handling and route identification capabilities across multiple components.
- Added ReflexURL class in
reflex/istate/data.pyextending str for enhanced URL parsing - Introduced factory method
RouterData.from_router_data()replacing direct initialization inreflex/app.pyand test files - Added
urlandroute_idfields to RouterData structure for better route tracking - Modified
asPathproperty in.templates/web/utils/state.jsto include window.location.hash - Note: Potential code duplication between headers.origin and page.host needs resolution
6 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5516 will not alter performanceComparing Summary
|
Lendemor
approved these changes
Jul 2, 2025
adhami3310
deleted the
add-url-and-route_id-to-routerdata-as-a-replacement-for-pagedata
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.