If we have set_focus() we need blur_focus().#5522
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Added a complementary blur_focus() event handler to match existing set_focus() functionality, enabling programmatic focus removal from elements.
- Added new
blur_focus()function inreflex/event.pyfollowing server-side event patterns - Implemented
_blur_focushandler in.templates/web/utils/state.jswith consistent ref resolution - Updated test suite in
tests/units/test_event.pyusing pytest parameterization to cover both focus events - Maintains existing type hints, docstrings, and error handling patterns throughout implementation
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
adhami3310
previously approved these changes
Jul 2, 2025
CodSpeed Performance ReportMerging #5522 will not alter performanceComparing Summary
|
Contributor
Author
|
|
Contributor
Author
|
Not sure why you're reliant on a 4yo deprecated linter... |
Member
a bit of two
|
adhami3310
approved these changes
Jul 2, 2025
Member
|
Thanks for the contribution! @riebecj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add's
blur_focus()server-side event for it'sset_focus()counterpart.All Submissions:
Type of change
New Feature Submission:
Changes To Core Features: