use deterministic hash for stateful component names#5525
Merged
adhami3310 merged 5 commits intoJul 3, 2025
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Implements a deterministic hashing system for stateful component names in reflex/components/component.py to ensure consistent component identification across different builds and environments.
- Added
_deterministic_hashfunction to handle complex object types including components, vars, dicts, and enums - Modified StatefulComponent class to use deterministic hashing instead of MD5 string hashing
- Enhanced hash calculation to maintain object structure integrity while processing nested data types
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5525 will not alter performanceComparing Summary
|
masenf
reviewed
Jul 3, 2025
Comment on lines
+511
to
+512
| if isinstance(value, float): | ||
| return _deterministic_hash(str(value)) |
Collaborator
There was a problem hiding this comment.
why not hash the float directly, like the int?
Member
Author
There was a problem hiding this comment.
_deterministic_hash has to return an int, so I'm not sure how to map it
masenf
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.