do not force import event and page#5559
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Major architectural changes to optimize module imports and reduce circular dependencies across the Reflex framework's core modules.
- Introduces
PageNamespaceandEventNamespaceclasses inreflex/page.pyandreflex/event.pyfor better module organization - Moves type checking imports behind
TYPE_CHECKINGinreflex/page.pyto reduce startup time - Removes direct imports of 'event' and 'page' in
reflex/__init__.py, implementing lazy loading through_MAPPING - Removes deprecated
_callback_arg_specfunction fromreflex/event.py
4 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5559 will not alter performanceComparing Summary
|
Lendemor
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.