Skip to content

do not force import event and page#5559

Merged
adhami3310 merged 3 commits into
mainfrom
do-not-force-import-event-and-page
Jul 28, 2025
Merged

do not force import event and page#5559
adhami3310 merged 3 commits into
mainfrom
do-not-force-import-event-and-page

Conversation

@adhami3310

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Major architectural changes to optimize module imports and reduce circular dependencies across the Reflex framework's core modules.

  • Introduces PageNamespace and EventNamespace classes in reflex/page.py and reflex/event.py for better module organization
  • Moves type checking imports behind TYPE_CHECKING in reflex/page.py to reduce startup time
  • Removes direct imports of 'event' and 'page' in reflex/__init__.py, implementing lazy loading through _MAPPING
  • Removes deprecated _callback_arg_spec function from reflex/event.py

4 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile

Comment thread reflex/page.py
Comment thread reflex/page.py
Comment thread reflex/event.py
@codspeed-hq

codspeed-hq Bot commented Jul 11, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #5559 will not alter performance

Comparing do-not-force-import-event-and-page (b267083) with main (7e0a95f)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit 2aa49a9 into main Jul 28, 2025
41 checks passed
@adhami3310 adhami3310 deleted the do-not-force-import-event-and-page branch July 28, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants