check port with bind over connect_ex#5564
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Improves port availability checking in reflex/utils/processes.py by switching from socket.connect_ex() to socket.bind() for more reliable port verification.
- Changed port checking method in
reflex/utils/processes.pyfromconnect_extobindfor more accurate availability detection - Added
PermissionErrorhandling to handle cases where port binding requires elevated privileges - Renamed
_is_address_responsiveto_can_bind_at_portto better reflect the new implementation's purpose - Inverted return logic in
is_process_on_portto align with bind-based checking semantics
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5564 will not alter performanceComparing Summary
|
masenf
approved these changes
Jul 11, 2025
|
@adhami3310 In Windows Subsystem for Linux WSL, the recursive change_port call can overflow the call stack and trigger a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.