Skip to content

fix attribute check for SQLAlchemy labeled column properties#5567

Merged
adhami3310 merged 1 commit into
reflex-dev:mainfrom
benedikt-bartscher:fix-attribute-check-for-sqla-labled-column-properties
Jul 16, 2025
Merged

fix attribute check for SQLAlchemy labeled column properties#5567
adhami3310 merged 1 commit into
reflex-dev:mainfrom
benedikt-bartscher:fix-attribute-check-for-sqla-labled-column-properties

Conversation

@benedikt-bartscher
Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 12, 2025

CodSpeed Performance Report

Merging #5567 will not alter performance

Comparing benedikt-bartscher:fix-attribute-check-for-sqla-labled-column-properties (4884568) with main (5890982)

Summary

✅ 8 untouched benchmarks

@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review July 12, 2025 07:53
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added a safety check for SQLAlchemy column nullable attribute access in reflex/utils/types.py to prevent AttributeError exceptions when handling special column types.

  • Modified get_attribute_access_type function to use hasattr() before accessing nullable attribute on SQLAlchemy columns
  • Improves handling of edge cases like hybrid properties and custom column types where nullable attribute might not exist

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@adhami3310 adhami3310 merged commit 19aae77 into reflex-dev:main Jul 16, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants