add window_event_listener#5568
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Added a new WindowEventListener component to handle window-level events with proper lifecycle management and TypeScript support.
- Implemented window event handlers for
resize,scroll,focus,blur,visibility_change,before_unload, andkeydownevents inreflex/components/core/window_events.py - Integrated proper event cleanup using React's useEffect to prevent memory leaks
- Component extends Fragment and excludes event handler props from prop drilling
- Added component exports via
rx.window_event_listenerin main module
4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5568 will not alter performanceComparing Summary
|
masenf
reviewed
Jul 16, 2025
Collaborator
masenf
left a comment
There was a problem hiding this comment.
code looks good. can we try to get @devin-ai-integration to write an AppHarness test to make sure all the features keep working
masenf
approved these changes
Jul 16, 2025
Collaborator
masenf
left a comment
There was a problem hiding this comment.
lets merge it and do the app harness test in another PR as a separate devin task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1314