Skip to content

pin rollup#5570

Merged
adhami3310 merged 1 commit into
mainfrom
pin-rollup
Jul 14, 2025
Merged

pin rollup#5570
adhami3310 merged 1 commit into
mainfrom
pin-rollup

Conversation

@adhami3310
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR pins the Rollup dependency to version 4.44.2 in the package.json overrides section. This is a defensive change made in response to a breaking bug introduced in Rollup 4.45.0 that causes build failures with the error 'Cannot add property 0, object is not extensible'. By explicitly setting this version constraint, we ensure build stability across the project.

The change is minimal but important, as Rollup is a critical build tool in our dependency chain, particularly through packages like rolldown-vite. The PR references a known issue tracked at rollup/rollup#6012.

Confidence score: 5/5

  1. This PR is very safe to merge as it's a defensive version pin to a known working version.
  2. High confidence score given because this is a well-documented issue with a clear fix, and the change is minimal with a proven stable version.
  3. Key files to review:
    • reflex/constants/installer.py (particularly the package.json OVERRIDES section)

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 14, 2025

CodSpeed Performance Report

Merging #5570 will not alter performance

Comparing pin-rollup (84cbd9b) with main (69d6eb5)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit e02405d into main Jul 14, 2025
39 of 41 checks passed
@adhami3310 adhami3310 deleted the pin-rollup branch July 14, 2025 20:28
adhami3310 added a commit that referenced this pull request Jul 14, 2025
adhami3310 added a commit that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants