ENG-6695: Do not allow call_script EventSpec to accept callback after being called

[masenf]

No description provided.

[linear]

ENG-6695 Do not allow `call_script` EventSpec to accept `callback` after being called

[greptile-apps]

Greptile Summary

This PR implements a defensive programming improvement in the call_script event handling system. The change modifies how callback handling is implemented by explicitly setting callback_kwargs to {"callback": None} instead of using an empty dictionary. This is a subtle but important change that prevents the possibility of callbacks being added to an EventSpec after it has been created, which could lead to unexpected behavior.

This change aligns with good programming practices by making the code's behavior more explicit and eliminating a potential source of bugs where callbacks could be modified after the fact.

Confidence score: 5/5

1. This PR is very safe to merge as it enforces stricter, more explicit behavior
2. The change is small, focused, and implements a clear defensive programming pattern
3. The event.py file needs review attention, but the changes are straightforward and well-contained

_{1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile}

[codspeed-hq]

CodSpeed Performance Report

Merging #5571 will not alter performance

_{Comparing masenf/no-patial-callback (53237c5) with main (e02405d)}

Summary

✅ 8 untouched benchmarks